Skip to content

bpo-36270: add link to traceback object reference in sys.exc_info docs - #13119

Merged
JulienPalard merged 4 commits into
python:masterfrom
bjoernmeier:bpo-36270
Sep 11, 2019
Merged

bpo-36270: add link to traceback object reference in sys.exc_info docs#13119
JulienPalard merged 4 commits into
python:masterfrom
bjoernmeier:bpo-36270

Conversation

@bjoernmeier

@bjoernmeier bjoernmeier commented May 6, 2019

Copy link
Copy Markdown
Contributor

Add a link pointing to the traceback object reference documentation
in the sys.exc_info return value documentation block.

https://bugs.python.org/issue36270

Add a link pointing to the traceback object reference documentation
in the sys.exc_info return value documentation block.
@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@csabella csabella left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request and thank you for for patience in waiting for a review. Just one small suggestion.

Comment thread Doc/library/sys.rst Outdated
Comment thread Doc/library/sys.rst Outdated

@Mariatta Mariatta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I removed the news file because it is not needed.
Made a suggestion on how to link the traceback object.

@Mariatta Mariatta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the suggested change.

@bedevere-bot

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @bjoernmeier for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
(cherry picked from commit 9936371)

Co-authored-by: Björn Meier <bjoern@opentrash.org>
@bedevere-bot

Copy link
Copy Markdown

GH-16002 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Sep 11, 2019
(cherry picked from commit 9936371)

Co-authored-by: Björn Meier <bjoern@opentrash.org>
DinoV pushed a commit to DinoV/cpython that referenced this pull request Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants